alamb commented on code in PR #10638: URL: https://github.com/apache/datafusion/pull/10638#discussion_r1613016952
########## datafusion-cli/Dockerfile: ########## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -FROM rust:1.73-bullseye as builder +FROM rust:1.78-bookworm as builder Review Comment: > The Rust version update is only for the build of the CLI. Nothing more. It's not related to the MSRV of DataFusion unless the build of the CLI is the litmus test that the MSRV we have actually builds and runs. I think the MSRV is verified via a CI job: https://github.com/apache/datafusion/blob/4b7b5ab11a868c0069245f411f0d9b08e1b2744e/.github/workflows/rust.yml#L556-L584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
