mustafasrepo commented on code in PR #10648: URL: https://github.com/apache/datafusion/pull/10648#discussion_r1615539401
########## datafusion/physical-expr-common/src/utils.rs: ########## @@ -100,15 +103,37 @@ pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr]) -> Vec<PhysicalSortExpr .collect() } +/// Converts `datafusion_expr::Expr` into corresponding `Arc<dyn PhysicalExpr>`. +/// If conversion is not supported yet, returns Error. +pub fn convert_logical_expr_to_physical_expr( Review Comment: renamed them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org