berkaysynnada commented on PR #10650: URL: https://github.com/apache/datafusion/pull/10650#issuecomment-2133239672
After talking with @ozankabak, we decided to undo the changes related to header options. There's also another place where `SessionState` is used in the `FileFormat` API: https://github.com/apache/datafusion/blob/ae107548bdccbb356b75f99edde3ce296532396e/datafusion/core/src/datasource/file_format/parquet.rs#L192 Suggesting that people should extract `SessionState` values during `TableProvider` creation might not be safe. I'm not sure if removing `SessionState` from this API is the right move, but it definitely needs more thought. Rushing to clean up the code could lead to losing functionality. We should discuss these in a different issue. For now, this PR only makes a small fix to `CastExpr`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
