Blizzara commented on PR #10653: URL: https://github.com/apache/datafusion/pull/10653#issuecomment-2133837045
@alamb Sounds good! here's an added test, though curious if you have any thoughts on how to make it simpler - given DF doesn't yet produce those compound names, I cannot use a roundtrip test, and writing the substrait manually feels both annoying and error-prone.. Using base64 encoded binary proto would be a bit easier but then there's some recent bad experiences with people uploading malicious stuff as "test binaries" so I didn't want to do that, but happy to if you'd find it better 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
