Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

[via GitHub]

andygrove commented on PR #473:
URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2133964232

   @viirya Just fyi, this commit caused a large regression for me in local runs 
of TPC-H. I will share full details tomorrow.
   
   ## before 
   
   ![Screenshot from 2024-05-27 
13-23-16](https://github.com/apache/datafusion-comet/assets/934084/76c57cb5-6b4c-4af0-a61c-3465e05a9429)
   
   ## after
   
   ![Screenshot from 2024-05-27 
13-23-31](https://github.com/apache/datafusion-comet/assets/934084/3c55a9b8-66ce-4070-8a8c-5d79582ed1a5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org