jonahgao commented on PR #10689: URL: https://github.com/apache/datafusion/pull/10689#issuecomment-2134804345
> I think current impl is correct, because the offset values after slicing is still offsetted based on original array. Else we have to do shifting for each offset elements like I think the shifting operation should be done internally in arrow-rs if needed, as it depends on what the data in the [values](https://github.com/apache/arrow-rs/blob/95791f1c317558a57b4570660f204bd9764426aa/arrow-array/src/array/list_array.rs#L130) looks like. Moreover, we don't need to do shifting for [FixedSizeListArray](https://github.com/apache/arrow-rs/blob/95791f1c317558a57b4570660f204bd9764426aa/arrow-array/src/array/fixed_size_list_array.rs#L282). The current solution looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
