sujithjay commented on code in PR #478:
URL: https://github.com/apache/datafusion-comet/pull/478#discussion_r1617923861


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -578,6 +578,24 @@ class CometExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
     }
   }
 
+  test("like with custom escape") {
+    val table = "names"
+    withTable(table) {
+      sql(s"create table $table(id int, name varchar(20)) using parquet")
+      sql(s"insert into $table values(1,'James Smith')")
+      sql(s"insert into $table values(2,'Michael_Rose')")
+      sql(s"insert into $table values(3,'Robert_R_Williams')")
+
+      // Filter column having values that include underscores
+      val queryDefaultEscape = sql("select id from names where name like 
'%\\_%'")
+      checkAnswer(queryDefaultEscape, Row(2) :: Row(3) :: Nil)

Review Comment:
   Done in 
https://github.com/apache/datafusion-comet/pull/478/commits/496e885da9c938519822bf021505e7fcf90395b5.
 Please review @kazuyukitanimura @andygrove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to