goldmedal commented on code in PR #10696:
URL: https://github.com/apache/datafusion/pull/10696#discussion_r1618064435
##########
datafusion/functions-aggregate/src/lib.rs:
##########
@@ -109,13 +109,13 @@ mod tests {
let mut names = HashSet::new();
for func in all_default_aggregate_functions() {
assert!(
- names.insert(func.name().to_string()),
+ names.insert(func.name().to_string().to_lowercase()),
Review Comment:
Thanks @jayzhan211
I think `to_lowercase` is used to ensure that the function name and its
alias won't be duplicates when case-insensitive (e.g., unquoted identifier). If
someone changes the function name to uppercase, the test will pass. However,
they may find that they can't query this function in lowercase. They might try
to add a lowercase alias or change the function name back to lowercase. I think
this is the purpose of this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
