Blizzara commented on code in PR #10719: URL: https://github.com/apache/datafusion/pull/10719#discussion_r1621348440
########## datafusion/substrait/src/variation_const.rs: ########## @@ -25,21 +25,23 @@ //! - Default type reference is 0. It is used when the actual type is the same with the original type. //! - Extended variant type references start from 1, and ususlly increase by 1. -// For type variations -pub const DEFAULT_TYPE_REF: u32 = 0; -pub const UNSIGNED_INTEGER_TYPE_REF: u32 = 1; -pub const TIMESTAMP_SECOND_TYPE_REF: u32 = 0; -pub const TIMESTAMP_MILLI_TYPE_REF: u32 = 1; -pub const TIMESTAMP_MICRO_TYPE_REF: u32 = 2; -pub const TIMESTAMP_NANO_TYPE_REF: u32 = 3; -pub const DATE_32_TYPE_REF: u32 = 0; -pub const DATE_64_TYPE_REF: u32 = 1; -pub const DEFAULT_CONTAINER_TYPE_REF: u32 = 0; -pub const LARGE_CONTAINER_TYPE_REF: u32 = 1; -pub const DECIMAL_128_TYPE_REF: u32 = 0; -pub const DECIMAL_256_TYPE_REF: u32 = 1; +// For [type variations](https://substrait.io/types/type_variations/#type-variations) in substrait. +// Type variations are used to represent different types based on one type class. +/// The "system-preferred" variation (i.e., no variation). Review Comment: Maybe add here something like a `TODO: move the non-system-preferred variations into a SimpleExtension` to make it clear that this is not the final form? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
