waynexia opened a new issue, #10732:
URL: https://github.com/apache/datafusion/issues/10732

   ### Describe the bug
   
   In #9960, `FIRST_VALUE` and `LAST_VALUE` are moved into another place, but 
that patch also changes the function signatures. They only accept `NUMERICS` 
after the PR. 
   
   
   
   ### To Reproduce
   
   Try the following query in CLI:
   
   d201ec742b08fa2a0549fc27f0b39622d67391ab
   
   ```sql
   SELECT arrow_typeof(FIRST_VALUE('0.1'::DECIMAL(4,1)));
   ```
   
   Result at d201ec742b08fa2a0549fc27f0b39622d67391ab (before #9960) is 
   ```sql
   +----------------------------------------+
   | arrow_typeof(FIRST_VALUE(Utf8("0.1"))) |
   +----------------------------------------+
   | Decimal128(4, 1)                       |
   +----------------------------------------+
   ```
   And after is
   ```sql
   +----------------------------------------+
   | arrow_typeof(first_value(Utf8("0.1"))) |
   +----------------------------------------+
   | Float64                                |
   +----------------------------------------+
   ```
   
   ### Expected behavior
   
   The output type changes because decimal is not one of `NUMERICS`. I can 
think of two points:
   - Should decimal be one of `NUMERICS`?
   - Should first/last value work like before?
   
   My perspective is "yes" for both.
   
   ### Additional context
   
   By the way, the function name also changes. From big letters to small 
letters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to