mustafasrepo opened a new pull request, #10742:
URL: https://github.com/apache/datafusion/pull/10742
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
While working on another PR, in which I implement a new custom rule. I hit a
usecase where I want to re-write `AggregateExpr`, and `WindowExpr` according to
some kind of projection. (For instance , in terms of the schema of the child).
In my use case, I find it useful to define an API `fn all_expressions(&self) ->
(function args, order bys, ..)` to return all expressions referred by the
aggregate or window function (By the way current `fn expressions(&self)` API
only returns function arguments).
With this API in place, we can update `Arc<dyn PhysicalExpr>`s, at the
outside (such as inside the rule). Then we can use updated expressions to
re-write `Arc<dyn AggregateExpr>` by using following API:
```rust
fn with_new_expressions(
&self,
_args: Vec<Arc<dyn PhysicalExpr>>,
_order_by_exprs: Vec<Arc<dyn PhysicalExpr>>,
) -> Option<Arc<dyn AggregateExpr>>
```
This behaviour, is very similar to the `fn expressions(), `, `fn
with_expressions()` methods for `LogicalPlan`s.
Also as far as I am aware @berkaysynnada's
[PR](https://github.com/synnada-ai/datafusion-upstream/pull/3) for projection
optimization will also require such an API, to be able to check pushdown an
aggregate expression or window expression successfully.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
