alamb commented on issue #8764: URL: https://github.com/apache/datafusion/issues/8764#issuecomment-2142173690
> @alamb let me know what you think. Thank you @marvinlanhenke -- I think the idea is valuable > Although, this might not be the best abstraction (since we need to provide the fixed_size) it might still have its benefits - in terms of consistency, maintainabiltiy, and testability? I think a large benefit would be the documentation about what the parameters meant (given this is so triky) > If you think its worth it, I'd proceed with implementing it in datafusion_common (anywhere specific here?). Thanks! I recommend https://github.com/apache/datafusion/tree/main/datafusion/common/src/utils (perhaps https://github.com/apache/datafusion/blob/main/datafusion/common/src/utils/proxy.rs but rename `proxy.rs` to `memory` or something 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
