berkaysynnada commented on PR #10404: URL: https://github.com/apache/datafusion/pull/10404#issuecomment-2142207464
> Doesn't really matter to me how it works, though I find the mismatch somewhat surprising - but mainly I just wanted to flag this in case this was not expected/intentional change. Thanks for reporting that. It's surprising that this issue hasn't emerged before. `CatalogOptions`'s has_header value was false as default from the beginning, which is the write options in that case. However, reader's is true: https://github.com/apache/datafusion/blob/09dde27be39ad054f85dfb5c37b7468a3f68d652/datafusion/core/src/datasource/file_format/options.rs#L90 I believe we should also set it as false while creating it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
