marvinlanhenke commented on PR #10748: URL: https://github.com/apache/datafusion/pull/10748#issuecomment-2143513377
> I see it's good abstraction. > > My only concern is, it seems that the original goal was kind of ideal, which just pass the hashtable and get the estimate size. But now before using this function, user have to calculate the fixed_size themself, and also the calculation is not always the same. > > Though the abstraction is not pretty enough, I think given the current code this PR is still an improvement. :) Yes, I totally agree with you on this. However, as discussed in the issue, it still might be worth it due to the improved documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
