MohamedAbdeen21 commented on code in PR #10700:
URL: https://github.com/apache/datafusion/pull/10700#discussion_r1623283870
##########
datafusion/functions/src/unicode/mod.rs:
##########
@@ -47,22 +47,64 @@ make_udf_function!(reverse::ReverseFunc, REVERSE, reverse);
make_udf_function!(rpad::RPadFunc, RPAD, rpad);
make_udf_function!(strpos::StrposFunc, STRPOS, strpos);
make_udf_function!(substr::SubstrFunc, SUBSTR, substr);
+make_udf_function!(substr::SubstrFunc, SUBSTRING, substring);
make_udf_function!(substrindex::SubstrIndexFunc, SUBSTR_INDEX, substr_index);
make_udf_function!(translate::TranslateFunc, TRANSLATE, translate);
pub mod expr_fn {
use datafusion_expr::Expr;
+ export_functions!((
+ character_length,
+ "the number of characters in the `string`",
+ string
+ ),(
+ lpad,
+ "fill up a string to the length by prepending the characters",
+ args,
+ ),(
+ rpad,
+ "fill up a string to the length by appending the characters",
+ args,
+ ),(
+ reverse,
+ "reverses the `string`",
+ string
+ ),(
+ substr,
+ "substring from the `position` to the end",
+ string position
+ ),(
+ substr_index,
+ "Returns the substring from str before count occurrences of the
delimiter",
+ string delimiter count
+ ),(
+ strpos,
+ "finds the position from where the `substring` matches the `string`",
+ string substring
+ ),(
+ substring,
+ "substring from the `position` with `length` characters",
+ string position length
+ ),(
+ translate,
+ "replaces the characters in `from` with the counterpart in `to`",
+ string from to
+ ),(
+ right,
+ "returns the last `n` characters in the `string`",
+ string n
+ ),(
+ left,
+ "returns the first `n` characters in the `string`",
+ string n
+ ));
+
#[doc = "the number of characters in the `string`"]
pub fn char_length(string: Expr) -> Expr {
character_length(string)
}
- #[doc = "the number of characters in the `string`"]
- pub fn character_length(string: Expr) -> Expr {
- super::character_length().call(vec![string])
- }
-
#[doc = "Returns a value in the range of 1 to N if the string str is in
the string list strlist consisting of N substrings"]
Review Comment:
@alamb extremely sorry about the accidental force push, meant to push with
lease after the rebase ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
