marvinlanhenke commented on PR #10748: URL: https://github.com/apache/datafusion/pull/10748#issuecomment-2143702360
@alamb I made the changes based on your comments. Thanks for the comprehensive review. 🚀 I changed `fn estimate_memory_size(..)` to return `Result<usize>` which should set us up for any possible future changes in the Accumulator trait; for now I simply unwrap in `fn size()` and panic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
