alamb commented on code in PR #10745:
URL: https://github.com/apache/datafusion/pull/10745#discussion_r1624921450
##########
datafusion/core/Cargo.toml:
##########
@@ -158,6 +159,16 @@ tokio-postgres = "0.7.7"
[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
nix = { version = "0.29.0", features = ["fs"] }
+[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
+aws-config = "0.101.0"
+aws-credential-types = "0.101.0"
+# the default features will cause libunwind error when testing on macos
paltform.
+object_store = { version = "0.9.1", default-features = false, features =
["aws", "gcp", "http"] }
Review Comment:
This is going to be problematic -- I don't think we can add these
dependencies to the core datafusion crate without massively increasing the
dependency footprint.
The idea is that the core of datafusion can be used from many places
(including wasm) that don't want the (very large) additional dependency of the
aws sdk. Having the dependencies in the DataFusion CLI is fine as it is the
standalone app (rather than a library)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
