viirya commented on code in PR #493:
URL: https://github.com/apache/datafusion-comet/pull/493#discussion_r1625107770
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -382,12 +384,13 @@ object CometConf {
.createWithDefault(Seq("Range,InMemoryTableScan"))
val COMET_ANSI_MODE_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.ansi.enabled")
+ .internal()
.doc(
"Comet does not respect ANSI mode in most cases and by default will not
accelerate " +
"queries when ansi mode is enabled. Enable this setting to test
Comet's experimental " +
"support for ANSI mode. This should not be used in production.")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(COMET_ANSI_MODE_ENABLED_DEFAULT)
Review Comment:
We may need to mention it is enabled by default for Spark 4.0 now. It could
produce incorrect results so we better don't make it implicitly enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
