andygrove commented on PR #505: URL: https://github.com/apache/datafusion-comet/pull/505#issuecomment-2147291617
> LGTM. Thanks for taking this over. I was about to ask chao if he is still working on the #373. > > > > It looks like the CI is still failed, you may take a look at that: > > ``` > > - unary negative integer overflow test *** FAILED *** (817 milliseconds) > > "[ARITHMETIC_OVERFLOW] short overflow. If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error. SQLSTATE: 22003" did not contain " caused overflow" (CometExpressionSuite.scala:1563) > > ``` It looks like the unary minus tests are failing in main as well for Spark 4. I think there was a conflict between two PRs that were merged yesterday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
