alamb commented on code in PR #10713:
URL: https://github.com/apache/datafusion/pull/10713#discussion_r1626301925
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -31,8 +31,10 @@ use datafusion::datasource::TableProvider;
use datafusion::execution::context::SessionState;
use datafusion::execution::runtime_env::{RuntimeConfig, RuntimeEnv};
use datafusion::execution::FunctionRegistry;
-use datafusion::functions_aggregate::expr_fn::{covar_pop, covar_samp,
first_value};
+use datafusion::functions_aggregate::covariance::{covar_pop, covar_samp};
+use datafusion::functions_aggregate::expr_fn::first_value;
Review Comment:
Can you please change this to `use` the exports from
`datafusion::functions_aggregate::expr_fn` (which I think is the intended
external facing API)?
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -651,6 +653,7 @@ async fn roundtrip_expr_api() -> Result<()> {
covar_pop(lit(1.5), lit(2.2)),
sum(lit(1)),
median(lit(2)),
+ var_sample(lit(2.2)),
Review Comment:
💯
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -149,7 +149,6 @@ impl From<protobuf::AggregateFunction> for
AggregateFunction {
protobuf::AggregateFunction::Count => Self::Count,
protobuf::AggregateFunction::ApproxDistinct =>
Self::ApproxDistinct,
protobuf::AggregateFunction::ArrayAgg => Self::ArrayAgg,
- protobuf::AggregateFunction::Variance => Self::Variance,
Review Comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
