parthchandra commented on code in PR #514:
URL: https://github.com/apache/datafusion-comet/pull/514#discussion_r1626312200
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2169,10 +2169,10 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
val trimCast = Cast(trimStr.get, StringType)
val trimExpr = exprToProtoInternal(trimCast, inputs)
val optExpr = scalarExprToProto(trimType, srcExpr, trimExpr)
- optExprWithInfo(optExpr, expr, null, srcCast, trimCast)
+ optExprWithInfo(optExpr, expr, srcCast, trimCast)
} else {
val optExpr = scalarExprToProto(trimType, srcExpr)
- optExprWithInfo(optExpr, expr, null, srcCast)
+ optExprWithInfo(optExpr, expr, srcCast)
Review Comment:
Thanks for finding and fixing this Andy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
