jayzhan211 commented on PR #10790: URL: https://github.com/apache/datafusion/pull/10790#issuecomment-2151148927
> Looks like a reasonable change to me. Thanks @jayzhan211 > > BTW I tested in duckdb and it seems like the default type is actually `int32` but I think `int64` is close enough > > ``` > D select []; > ┌───────────────────┐ > │ main.list_value() │ > │ int32[] │ > ├───────────────────┤ > │ [] │ > └───────────────────┘ > ``` Yes, they use i32. The reason I choose i64 is that the default value in datafusion is mostly i64 so we can avoid the cast for most of the case. We can easily convert it to i32 anytime if there is any need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
