viirya commented on code in PR #523:
URL: https://github.com/apache/datafusion-comet/pull/523#discussion_r1628700174
##########
core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -947,12 +948,18 @@ async fn external_shuffle(
partitioning,
metrics,
context.runtime_env(),
- context.session_config().batch_size(),
+ batch_size,
);
while let Some(batch) = input.next().await {
let batch = batch?;
- repartitioner.insert_batch(batch).await?;
+ let mut start = 0;
+ while start < batch.num_rows() {
+ let end = (start + batch_size).min(batch.num_rows());
+ let batch = batch.slice(start, end - start);
+ repartitioner.insert_batch(batch).await?;
+ start = end;
+ }
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
