jayzhan211 commented on code in PR #10816:
URL: https://github.com/apache/datafusion/pull/10816#discussion_r1630434594
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -5334,3 +5334,34 @@ physical_plan
03)----AggregateExec: mode=Partial, gby=[],
aggr=[first_value(convert_first_last_table.c1) ORDER BY
[convert_first_last_table.c2 DESC NULLS FIRST]]
04)------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
05)--------CsvExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/convert_first_last.csv]]},
projection=[c1, c2], output_orderings=[[c1@0 ASC NULLS LAST], [c2@1 DESC]],
has_header=true
+
+# test building plan with aggreagte sum
Review Comment:
move the corresponding test in datafusion_expr to avoid introducing another
stub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
