andygrove commented on code in PR #519:
URL: https://github.com/apache/datafusion-comet/pull/519#discussion_r1630655033
##########
fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala:
##########
@@ -106,4 +106,8 @@ object Meta {
Function("stddev_samp", 1),
Function("corr", 2))
+ val unaryArithmeticOps: Seq[String] = Seq("+", "-")
+
+ val binaryArithmeticOps: Seq[String] = Seq("+", "-", "*", "/", "%", "&",
"|", "^")
Review Comment:
Thsi PR was focussing on arithmetic because it is related to the ongoing
work to support ANSI mode, but yet, we should add tests for comparison
operators as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
