andygrove commented on code in PR #10765:
URL: https://github.com/apache/datafusion/pull/10765#discussion_r1631186375
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1545,8 +1545,13 @@ mod tests {
input_schema,
)?);
- let result =
- common::collect(merged_aggregate.execute(0,
task_ctx.clone())?).await?;
+ // enlarge memory limit in spill mode
+ let task_ctx = if spill {
+ new_spill_ctx(2, 2600)
Review Comment:
I hadn't realized that these literal values were just in tests ... thanks
for the explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]