peter-toth commented on issue #10808: URL: https://github.com/apache/datafusion/issues/10808#issuecomment-2154884925
@LorrensP-2158466, I as far as I get you just want to change the return type of `LogicalPlan ::inputs()` to use iterators instead of the current `Vec`. I think that is not really related to https://github.com/apache/datafusion/pull/10543 and actually can be a good idea to avoid unnecessary `Vec` allocations. But I feel you will run into issues with the `impl Iterator<Item = &LogicalPlan>` return type as it doesn't allow to return different iterator implementations on different `LogicalPlan`s. (And I think we want to avoid `dyn Iterator` too.) But please give it a try if you have some time... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
