goldmedal commented on code in PR #10834:
URL: https://github.com/apache/datafusion/pull/10834#discussion_r1632070143
##########
datafusion/physical-expr/src/aggregate/build_in.rs:
##########
@@ -747,82 +731,6 @@ mod tests {
Ok(())
}
- #[test]
- fn test_stddev_expr() -> Result<()> {
Review Comment:
Same as above. It's already covered by sqllogictests.
##########
datafusion/physical-expr/src/aggregate/build_in.rs:
##########
@@ -747,82 +731,6 @@ mod tests {
Ok(())
}
- #[test]
- fn test_stddev_expr() -> Result<()> {
- let funcs = vec![AggregateFunction::Stddev];
- let data_types = vec![
- DataType::UInt32,
- DataType::UInt64,
- DataType::Int32,
- DataType::Int64,
- DataType::Float32,
- DataType::Float64,
- ];
- for fun in funcs {
- for data_type in &data_types {
- let input_schema =
- Schema::new(vec![Field::new("c1", data_type.clone(),
true)]);
- let input_phy_exprs: Vec<Arc<dyn PhysicalExpr>> =
vec![Arc::new(
- expressions::Column::new_with_schema("c1",
&input_schema).unwrap(),
- )];
- let result_agg_phy_exprs = create_physical_agg_expr_for_test(
- &fun,
- false,
- &input_phy_exprs[0..1],
- &input_schema,
- "c1",
- )?;
- if fun == AggregateFunction::Stddev {
- assert!(result_agg_phy_exprs.as_any().is::<Stddev>());
- assert_eq!("c1", result_agg_phy_exprs.name());
- assert_eq!(
- Field::new("c1", DataType::Float64, true),
- result_agg_phy_exprs.field().unwrap()
- )
- }
- }
- }
- Ok(())
- }
-
- #[test]
- fn test_stddev_pop_expr() -> Result<()> {
Review Comment:
Same as above. It's already covered by sqllogictests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
