goldmedal commented on issue #10838: URL: https://github.com/apache/datafusion/issues/10838#issuecomment-2156334969
Hi @jayzhan211, After some research, I found that `approx_median` heavily relies on `ApproxPercentileCont` for accumulation. https://github.com/goldmedal/datafusion/blob/1600a307f272f9c716131dcca7a55ba1761774a6/datafusion/physical-expr/src/aggregate/approx_median.rs#L46 I think we should convert `ApproxPercentileCont` to a UDAF first. We can move `ApproxPercentileCont` and `TDigest` to `function-aggregate`, so that `ApproxMedian` can use them. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
