MohamedAbdeen21 commented on code in PR #10832:
URL: https://github.com/apache/datafusion/pull/10832#discussion_r1632227588
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -782,9 +786,11 @@ impl TreeNodeRewriter for CommonSubexprRewriter<'_> {
return Ok(Transformed::new(expr, false, TreeNodeRecursion::Jump));
}
- let (up_index, expr_id) = &self.id_array[self.down_index];
+ let (up_index, expr_id, aliased) = &self.id_array[self.down_index];
self.down_index += 1;
+ self.aliased |= aliased;
Review Comment:
Ok, I see what you mean.
I can get behind implementing the `f_up`, but the expression you provided
doesn't even parse. If you can provide a query that shows the need for an alias
stack I'd be happy to implement it.
In other words, can you think of a test case where Alias is a child and not
the root of an expr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
