andygrove commented on code in PR #546:
URL: https://github.com/apache/datafusion-comet/pull/546#discussion_r1632321812
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -78,8 +78,12 @@ pub(crate) fn spark_compatible_murmur3_hash<T:
AsRef<[u8]>>(data: T, seed: u32)
}
h1
}
+
let data = data.as_ref();
let len = data.len();
+ if len == 0 {
+ return seed;
Review Comment:
I am not sure if this is the correct return value for an empty slice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
