jayzhan211 commented on code in PR #10840: URL: https://github.com/apache/datafusion/pull/10840#discussion_r1632439168
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -509,6 +509,10 @@ SELECT approx_median(c12) FROM aggregate_test_100 ---- 0.555006541052 +# csv_query_approx_median_4 +statement error Review Comment: It would be nice to add a comment here `# test with string, approx_median only support numeric` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
