tinfoil-knight commented on code in PR #9723:
URL: https://github.com/apache/datafusion/pull/9723#discussion_r1633227239
##########
datafusion/sql/src/statement.rs:
##########
@@ -850,7 +850,16 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
return plan_err!("Unsupported Value in COPY statement {}",
value);
}
};
- options.insert(key.to_lowercase(), value_string.to_lowercase());
+ if !(&key.contains('.')) {
+ // If config does not belong to any namespace, assume it is
+ // a format option and apply the format prefix for backwards
+ // compatibility.
+
+ let renamed_key = format!("format.{}", key);
+ options.insert(renamed_key.to_lowercase(),
value_string.to_lowercase());
Review Comment:
I've opened an issue here: https://github.com/apache/datafusion/issues/10853
Making the value standardization logic customizable makes sense.
Integrations should receive the original value and be able to decide what to do
with it.
I'll attempt a fix for the issue this weekend if it hasn't already been
picked up by then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
