sadboy commented on PR #10850: URL: https://github.com/apache/datafusion/pull/10850#issuecomment-2158587271
> if we could update at least one callsite to use `try_new_with_schema` so we get some test coverage `Window::try_new` actually calls `try_new_with_schema` to do the work, that's why I didn't bother adding new tests. Do you think that's sufficient coverage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
