Lordworms commented on code in PR #10842:
URL: https://github.com/apache/datafusion/pull/10842#discussion_r1633563140
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -569,7 +571,80 @@ pub async fn from_substrait_rel(
Ok(LogicalPlan::Values(Values { schema, values }))
}
- _ => not_impl_err!("Only NamedTable and VirtualTable reads are
supported"),
+ Some(ReadType::LocalFiles(lf)) => {
+ fn extract_filename(name: &str) -> Option<String> {
+ let corrected_url =
+ if name.starts_with("file://") &&
!name.starts_with("file:///") {
+ name.replacen("file://", "file:///", 1)
Review Comment:
the file name in those json files are all starts with FILE:// which makes it
impossible for url librarary to parse so I did the transformation, or we could
try direct string parse otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
