Lordworms commented on code in PR #10851:
URL: https://github.com/apache/datafusion/pull/10851#discussion_r1633650126
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -304,3 +223,88 @@ where
default_accumulator_impl!();
}
+
+impl Debug for ApproxDistinct {
+ fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+ f.debug_struct("ApproxDistinct")
+ .field("name", &self.name())
+ .field("signature", &self.signature)
+ .finish()
+ }
+}
+
+impl Default for ApproxDistinct {
+ fn default() -> Self {
+ Self::new()
+ }
+}
+
+pub struct ApproxDistinct {
+ signature: Signature,
+ alias: Vec<String>,
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]