alamb commented on code in PR #10829:
URL: https://github.com/apache/datafusion/pull/10829#discussion_r1633891932
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -367,9 +372,9 @@ async fn implicit_cast() -> Result<()> {
async fn aggregate_case() -> Result<()> {
assert_expected_plan(
"SELECT SUM(CASE WHEN a > 0 THEN 1 ELSE NULL END) FROM data",
- "Aggregate: groupBy=[[]], aggr=[[SUM(CASE WHEN data.a > Int64(0) THEN
Int64(1) ELSE Int64(NULL) END)]]\
+ "Aggregate: groupBy=[[]], aggr=[[SUM(CASE WHEN data.a > Int64(0) THEN
Int64(1) ELSE Int64(NULL) END) AS SUM(CASE WHEN data.a > Int64(0) THEN Int64(1)
ELSE NULL END)]]\
\n TableScan: data projection=[a]",
- false // NULL vs Int64(NULL)
+ true
Review Comment:
🎉
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -694,20 +690,14 @@ async fn all_type_literal() -> Result<()> {
#[tokio::test]
async fn roundtrip_literal_list() -> Result<()> {
- assert_expected_plan(
- "SELECT [[1,2,3], [], NULL, [NULL]] FROM data",
- "Projection: List([[1, 2, 3], [], , []])\
- \n TableScan: data projection=[]",
- false, // "List(..)" vs "make_array(..)"
- )
- .await
+ roundtrip("SELECT [[1,2,3], [], NULL, [NULL]] FROM data").await
Review Comment:
I verified that `roundtrip` actually is more stringent than
`assert_expected_plan` as it checks the plan before and after roundtripping 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
