marvinlanhenke commented on PR #10852: URL: https://github.com/apache/datafusion/pull/10852#issuecomment-2159755434
> So how about this for a plan: > > 1. You polish up this PR (it looks like there are some doc comments to update) > 2. I will file a follow on ticket to make a test with multiple datapages in a row group > 3. Once we have done a few more types, I'll file a bunch more tickets to fill out the DataTypes as we did for row group @alamb Thanks for the early review here. Your plan how to proceed sounds good to me. Perhaps we can do the test with multiple datapages in this PR? So we have a correct version in place before merging and filing out tickets for more datatype support? So I'd like to finish polishing this PR with adding docs and the extra test setup for multiple datapages. Some other todos which I have on my list (which could all be follow up PRs): - support other datatypes (+ add tests -> `test_data_page_statistics:bool = true`) - integrate new API in `page_filter.rs` - add benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
