andygrove commented on code in PR #552:
URL: https://github.com/apache/datafusion-comet/pull/552#discussion_r1634865551
##########
core/src/execution/datafusion/expressions/scalar_funcs/chr.rs:
##########
@@ -110,7 +118,7 @@ fn handle_chr_fn(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
Some(ch) => Ok(ColumnarValue::Scalar(ScalarValue::Utf8(Some(
ch.to_string(),
)))),
- None => exec_err!("requested character too large for
encoding."),
+ None => exec_err!("requested character was incompatible for
encoding."),
Review Comment:
We don't have the checks for negative integers in the scalar path. I wonder
if this code path is even possible to reach since Spark will likely evaluate
`chr(scalar)` during planning and replace it with a literal value before the
physical planning stage, so Comet would never see this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
