eejbyfeldt commented on code in PR #542:
URL: https://github.com/apache/datafusion-comet/pull/542#discussion_r1635060236
##########
core/src/parquet/read/values.rs:
##########
@@ -797,8 +797,9 @@ impl PlainDecoding for Int96TimestampMicrosType {
let nanos = &v[..INT96_DST_BYTE_WIDTH] as *const [u8] as
*const u8 as *const i64;
let day = &v[INT96_DST_BYTE_WIDTH..] as *const [u8] as *const
u8 as *const i32;
- let micros = (day.read_unaligned() - JULIAN_DAY_OF_EPOCH) as
i64 * MICROS_PER_DAY
- + nanos.read_unaligned() / 1000;
+ let micros = ((day.read_unaligned() - JULIAN_DAY_OF_EPOCH) as
i64)
Review Comment:
Fixed in
https://github.com/apache/datafusion-comet/pull/542/commits/a4be042fbde46dbb611906d780c71b697e785e37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
