kazuyukitanimura commented on code in PR #537:
URL: https://github.com/apache/datafusion-comet/pull/537#discussion_r1635390552
##########
common/src/main/java/org/apache/comet/parquet/TypeUtil.java:
##########
@@ -169,6 +170,7 @@ && isUnsignedIntTypeMatched(logicalTypeAnnotation, 64)) {
break;
case INT96:
if (sparkType == TimestampNTZType$.MODULE$) {
+ if (isSpark40Plus()) return;
Review Comment:
Added a comment. I feel we do not need to log because this return will be a
regular code path for newer Spark versions
##########
spark/src/main/spark-3.2/org/apache/comet/shims/CometExprShim.scala:
##########
@@ -32,6 +33,12 @@ trait CometExprShim {
(unhex.child, Literal(false))
}
+ protected def isTimestampNTZType(dt: DataType): Boolean = dt match {
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
