tshauck opened a new pull request, #10890:
URL: https://github.com/apache/datafusion/pull/10890

   ## Which issue does this PR close?
   
   Closes #.
   
   ## Rationale for this change
   
   This is a POC I was hoping to get feedback on to see if it's inline with the 
project goals before making it merge-worthy.
   
   The idea is to add a `CliSessionContext` trait, which is used in the CLI in 
place of `SessionContext`. In doing so, I hope to make it possible for code in 
the `datafusion-cli` crate for a custom `SessionContext` like:
   
   ```rust
   struct MyFancySessionContext {
     ctx: SessionContext
   }
   
   impl CliSessionContext for MyFancySessionContext {}
   
   exec_from_commands(
   ```
   
   ## What changes are included in this PR?
   
   * Adds a `CliSessionContext` trait.
   * Updates the CLI entrypoint and related code to use a `CliSessionContext` 
instead of a `SessionContext` directly. 
   * Implements `CliSessionContext` for `SessionContext`
   
   ## Are these changes tested?
   
   I've tested locally and things seem to compile and are useable. Certainly, 
more work needed to make it ready to merge.
   
   ## Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to