alamb commented on code in PR #10891:
URL: https://github.com/apache/datafusion/pull/10891#discussion_r1637141726
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -414,21 +422,20 @@ impl JoinFuzzTestCase {
nlj_formatted.trim().lines().collect();
nlj_formatted_sorted.sort_unstable();
- assert_eq!(
- smj_formatted_sorted.len(),
- hj_formatted_sorted.len(),
- "SortMergeJoinExec and HashJoinExec produced different row
counts"
- );
- for (i, (smj_line, hj_line)) in smj_formatted_sorted
- .iter()
- .zip(&hj_formatted_sorted)
- .enumerate()
- {
- assert_eq!(
- (i, smj_line),
- (i, hj_line),
- "SortMergeJoinExec and HashJoinExec produced different
results"
- );
+ // row level compare if any of joins returns the result
+ // the reason is different formatting when there is no rows
+ if smj_rows > 0 || hj_rows > 0 {
Review Comment:
I double checked that the assert on row count is done higher up 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
