eejbyfeldt commented on code in PR #543:
URL: https://github.com/apache/datafusion-comet/pull/543#discussion_r1638389361
##########
core/src/execution/datafusion/expressions/utils.rs:
##########
@@ -81,12 +81,12 @@ pub fn array_with_timezone(
array: ArrayRef,
timezone: String,
to_type: Option<&DataType>,
-) -> ArrayRef {
+) -> Result<ArrayRef, ArrowError> {
Review Comment:
Could you expand on which case you are referring to here? Because I thought
making it return an error instead of panicking is exactly what I did in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
