svranesevic opened a new pull request, #10912: URL: https://github.com/apache/datafusion/pull/10912
## Which issue does this PR close? / ## Rationale for this change Noticed while using `LogicalPlan::Copy` with `FormatOptions::CSV` that `escape` and `quote` options were not reflected in resulting CSV file. ## What changes are included in this PR? - Fix some of the `FormatOptions::CSV(CsvOptions)` not being propagated to/from protos - https://github.com/apache/datafusion/commit/75a9b4c3f30f5c2b4ea0b7ea91e677c28d398ebf - Add `double_quote` to `CsvOptions` options - https://github.com/apache/datafusion/commit/75a9b4c3f30f5c2b4ea0b7ea91e677c28d398ebf - Fix wrong schema passed in to `DataSinkExec` when decoding `JsonSink`, `CsvSink`, and `ParquetSink` - https://github.com/apache/datafusion/commit/65ad9b6ceaea7372ba215ab66607204900c583ef - Sink output schema was passed in, but sink input schema was expected. - Caught by failing debug assertion - https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/insert.rs#L130-L133 ## Are these changes tested? First time contributor, would need guidance how/if to test these best. ## Are there any user-facing changes? - Add `double_quote` to `CsvOptions` options - https://github.com/apache/datafusion/commit/75a9b4c3f30f5c2b4ea0b7ea91e677c28d398ebf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
