alamb commented on code in PR #10947:
URL: https://github.com/apache/datafusion/pull/10947#discussion_r1642517516
##########
datafusion/common/src/column.rs:
##########
@@ -109,21 +109,21 @@ impl Column {
/// `foo.BAR` would be parsed to a reference to relation `foo`, column
name `bar` (lower case)
/// where `"foo.BAR"` would be parsed to a reference to column named
`foo.BAR`
pub fn from_qualified_name(flat_name: impl Into<String>) -> Self {
Review Comment:
I think we could make this significantly better for the common case (non
error) by changing the signature to take `&str` but that would be a breaking
change, and I think we should only do it if benchmarking shows it helps.
Most of the time is actually taken parsing the identifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
