marvinlanhenke commented on PR #10946: URL: https://github.com/apache/datafusion/pull/10946#issuecomment-2173158573
> Thank you very much @marvinlanhenke -- I think this looks great to me > > I see the complication related to data_page_row_counts. I don't have a great answer for that at the moment other than potentially to return an error. > > I believe this PR could be merged in as is and we can update the behavior in a follow on PR (or leave it as is for a while). Let me know what you think @alamb Thanks for the review. I left one question regarding the current impl of `row_group_row_counts` ... if this question does not help regarding data_pages_row_count, I'm a +1 for returning an error instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
