andygrove commented on code in PR #579:
URL: https://github.com/apache/datafusion-comet/pull/579#discussion_r1642918541
##########
core/build.rs:
##########
@@ -20,7 +20,7 @@
use std::{fs, io::Result, path::Path};
fn main() -> Result<()> {
- println!("cargo:rerun-if-changed=src/execution/proto/*.proto");
+ println!("cargo:rerun-if-changed=src/execution/proto/");
Review Comment:
This change seems correct to me. The docs state that the syntax is
[cargo::rerun-if-changed=PATH](https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed)
and adds these notes:
```
The rerun-if-changed instruction tells Cargo to re-run the build script if
the file at the given path has changed. Currently, Cargo only uses the
filesystem last-modified “mtime” timestamp to determine if the file has
changed. It compares against an internal cached timestamp of when the build
script last ran.
If the path points to a directory, it will scan the entire directory for any
modifications.
```
##########
core/build.rs:
##########
@@ -20,7 +20,7 @@
use std::{fs, io::Result, path::Path};
fn main() -> Result<()> {
- println!("cargo:rerun-if-changed=src/execution/proto/*.proto");
+ println!("cargo:rerun-if-changed=src/execution/proto/");
Review Comment:
This change seems correct to me. The docs state that the syntax is
[cargo::rerun-if-changed=PATH](https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed)
and adds these notes:
The rerun-if-changed instruction tells Cargo to re-run the build script if
the file at the given path has changed. Currently, Cargo only uses the
filesystem last-modified “mtime” timestamp to determine if the file has
changed. It compares against an internal cached timestamp of when the build
script last ran.
If the path points to a directory, it will scan the entire directory for any
modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
