jonahgao commented on code in PR #10954:
URL: https://github.com/apache/datafusion/pull/10954#discussion_r1642946733
##########
datafusion/sql/src/query.rs:
##########
@@ -29,23 +29,17 @@ use sqlparser::ast::{
};
impl<'a, S: ContextProvider> SqlToRel<'a, S> {
- /// Generate a logical plan from an SQL query
+ /// Generate a logical plan from an SQL query/subquery
pub(crate) fn query_to_plan(
&self,
query: Query,
- planner_context: &mut PlannerContext,
+ outer_planner_context: &mut PlannerContext,
) -> Result<LogicalPlan> {
- self.query_to_plan_with_schema(query, planner_context)
- }
+ // Each query has its own planner context, including CTEs that are
visible within that query.
+ // It also inherits the CTEs from the outer query by cloning the outer
planner context.
+ let mut query_plan_context = outer_planner_context.clone();
+ let planner_context = &mut query_plan_context;
- /// Generate a logic plan from an SQL query.
- /// It's implementation of `subquery_to_plan` and `query_to_plan`.
- /// It shouldn't be invoked directly.
- fn query_to_plan_with_schema(
Review Comment:
`subquery_to_plan` no longer exists, and `query_to_plan` was its only
caller, so it has been merged into `query_to_plan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
