tshauck commented on code in PR #10963: URL: https://github.com/apache/datafusion/pull/10963#discussion_r1643410255
########## datafusion/sqllogictest/test_files/subquery.slt: ########## @@ -613,10 +613,7 @@ SELECT t1_id, t1_name FROM t1 WHERE EXISTS (SELECT * FROM t2 WHERE t2_id = t1_id query TT explain SELECT t1_id, t1_name FROM t1 WHERE EXISTS (SELECT * FROM t2 WHERE t2_id = t1_id limit 0) ---- -logical_plan -01)LeftSemi Join: t1.t1_id = __correlated_sq_1.t2_id -02)--TableScan: t1 projection=[t1_id, t1_name] -03)--EmptyRelation +logical_plan EmptyRelation Review Comment: I think the EmptyRelation in the original test is causing the entire join to be optimized out with the additional join types now propagating emptyrelation. Is there a way I can preserve this test's testing of just the subquery rewrite logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
